ethereum-optimism.github.io icon indicating copy to clipboard operation
ethereum-optimism.github.io copied to clipboard

Base address for UNI

Open jbarber13 opened this issue 10 months ago • 6 comments

Description

Add the UNI address to the token list for the Base bridge.

jbarber13 avatar Apr 16 '24 21:04 jbarber13

Hi @jbarber13 can we separate this into a PR for each token? For the USDT token, can this be redeployed with the newest token factory? https://docs.base.org/docs/base-contracts#base-mainnet It currently looks like a copy of the OP version from 8/21

cfluke-cb avatar Apr 17 '24 14:04 cfluke-cb

@cfluke-cb Hi,

I removed the USDT stuff from this PR, I'll make another one for USDT.

jbarber13 avatar Apr 17 '24 20:04 jbarber13

your json is broken

@rcbgr Can you elaborate on what is wrong with the JSON? It passes when I run the validation image

jbarber13 avatar Apr 26 '24 23:04 jbarber13

@jbarber13

Heya, are you affiliated with Uniswap?

wbnns avatar Apr 27 '24 00:04 wbnns

@wbnns

Heya, are you affiliated with Uniswap?

Hello, I am with GFX Labs, we are a delegate for Uniswap.

jbarber13 avatar Apr 29 '24 20:04 jbarber13

@jbarber13

Thanks for confirming! We should hopefully have an update soon. We are also confirming via our channels with the Uniswap team that they would like this to be the canonical UNI on Base.

wbnns avatar May 01 '24 00:05 wbnns

@jbarber13

Heya! Thanks for your patience, just wanted to follow-up! Can you link to any governance post alongside this deployment that would confirm it's approval?

wbnns avatar May 08 '24 00:05 wbnns

Hey - gov lead from the uniswap foundation here (eek37 on the forum and on twitter). There is no gov post saying "the address of UNI on Base is 0x...". However, there is a post proposing to provide UNI-denominated liquidity incentives to L2 deployments of the protocol here. Base is one of those L2s, and UNI incentives are currently being provided via a Merlkl distributor contract on three pools (see deets here.

This proposal's author was Getty Hill who founded GFX. The proposal passed and GFX has helped to implement by, among other things deploying the token on various L2 chain including base ( https://basescan.org/token/0xc3de830ea07524a0761646a6a4e4be0e114a3c83#code).

Thanks

erin-koen avatar May 08 '24 13:05 erin-koen

@erin-koen

Heya! Thanks for these details! We're reviewing and will follow-up asap. Appreciate all of the additional context. 🤝

wbnns avatar May 09 '24 01:05 wbnns

Merge failed. Please see automated check logs for more details.

mergify[bot] avatar May 15 '24 16:05 mergify[bot]