ethereum-optimism.github.io icon indicating copy to clipboard operation
ethereum-optimism.github.io copied to clipboard

Update LIKE data.json (update token symbol to match contract)

Open ENSpunks opened this issue 10 months ago • 7 comments

The admins changed the folder name from “❤️” to “LIKE” because the emoji as a folder name was problematic for the repo, but when the folder name was change the admins also changed the token symbol in error, this PR edits the token symbol back to “❤️” consistent with both the Ethereum Mainnet and Base contracts.

Description

A clear and concise description of the features you're adding in this pull request.

Tests

Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.

Additional context

Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

ENSpunks avatar Apr 06 '24 09:04 ENSpunks

Hi, looks like my PR was blocked.

It’s just updating the token symbol to match the contracts.

anything I can/should do?

ENSpunks avatar Apr 29 '24 19:04 ENSpunks

Hi, see below there no logs for this, and no error handling (since it’s uncommon). Again the original PR and merge the token symbol was correct and I just received an email one day saying it was changed, can they just update it or revert it?

really not sure

image

ENSpunks avatar May 01 '24 20:05 ENSpunks

Does this sound right?

The tokenlist “overriding” was either done manually by the maintainers when they changed the token symbol or it was done automatically when they did the change.

sorry I’m not technical and don’t know how to remove the over right that got added when the token symbol was change by the maintainers from “❤️” to “Like”

ENSpunks avatar May 02 '24 01:05 ENSpunks

Apologies for the double-post, looks like there might have been an intermittent issue with GitHub when I added the last comment.

wbnns avatar May 03 '24 01:05 wbnns

@wbnns

thank you, overrides removed, I believe it will validate now

ENSpunks avatar May 03 '24 02:05 ENSpunks

@wbnns

Added "nonstandard": true,

ENSpunks avatar May 03 '24 10:05 ENSpunks

I think I figured it out, I added a new commit to the PR to update the tokenlist in addition to the data.json

ENSpunks avatar May 07 '24 02:05 ENSpunks

@ENSpunks

Thanks for the update, I think the issue is that the validation script doesn't support emojis.

Cc: @hamdiallam

wbnns avatar May 08 '24 00:05 wbnns

Ah yes sorry for not chiming in earlier. This validation script was failing when checking against uniswap's tokenlist schema

I double checked and it looks like the latest uniswap schema supports unicode for the symbol. I put up #822. When that's merged in can you rebase and we'll get your token merged in.

I'd pref our folder names to not have any emoji symbols. The override approach here feels appropriate

hamdiallam avatar May 08 '24 16:05 hamdiallam

hey @ENSpunks can you rebase this PR so you pickup the changes in #822?

hamdiallam avatar May 14 '24 21:05 hamdiallam

I think the easiest way for me to rebase would be close this PR, delete my copy of the repo, fork the repo again and open a new PR. Is that ok?

ENSpunks avatar May 15 '24 02:05 ENSpunks

@ENSpunks Sure, if you want to! Or if you want to give rebasing a go, feel free to try it out!

wbnns avatar May 15 '24 03:05 wbnns