baseline icon indicating copy to clipboard operation
baseline copied to clipboard

Generalize the Shield contract transaction types

Open Perseverance opened this issue 4 years ago • 3 comments

The current Shield contract, part of the Radish34 setup has TransactionTypes tailored to the Radish use case. In order to make this contract more reusable in other use-cases the transaction types can be dynamically created.

Idea how this can be implemented: Remove the transactionTypes enum and add a method allowing the administrator to add new transaction types (index, name). Change radish34 deployment procedure and tests to account for calling this method to set up the transaction types. Allow for inspection of transaction type name by index.

Perseverance avatar Apr 23 '20 05:04 Perseverance

Good issue! Shield i think could fit into the overall "upgradable" pattern

skarred14 avatar Apr 24 '20 18:04 skarred14

I am starting to look into this story, please let me know if there is any conflict.

davemec avatar Sep 11 '20 17:09 davemec

@Kasshern @skosito @Ybittan @biscuitdey This discussion might be relevant for our work on the SRI. Keeping it open so that we can discuss.

ognjenkurtic avatar Jul 28 '22 08:07 ognjenkurtic