chains icon indicating copy to clipboard operation
chains copied to clipboard

Replace Wanchain Testnet with HyperEVM (chainId 999)

Open ChiTimesChi opened this issue 8 months ago • 5 comments

Replaces #6840, which seems to be stale.

ChiTimesChi avatar Apr 18 '25 12:04 ChiTimesChi

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

github-actions[bot] avatar Apr 18 '25 12:04 github-actions[bot]

The gradlew checks pass locally, and running prettier results in an empty diff.

@FrederikBolding @ligi could you please help with approving the CI workflows and the PR as well?

ChiTimesChi avatar Apr 23 '25 10:04 ChiTimesChi

@FrederikBolding @ligi bumping this PR :pray:

ChiTimesChi avatar Apr 30 '25 10:04 ChiTimesChi

Still actual PR. Hyperevm has been live for some time, so seems like it is a critical entry in the list.

airled avatar May 29 '25 08:05 airled

Bumping, important issue.

0xVorian avatar Jun 17 '25 17:06 0xVorian

What is the status here? Any reason why this is not merged? Would be nice to have hyperEVM support in viem and this is one of the requirements.

pdjsh avatar Jul 15 '25 10:07 pdjsh

@ChiTimesChi @FrederikBolding How do we go ahead about merging this, I'm integrating hyperEVM and would really appreciate getting this merged if there are no blockers around it

pdjsh avatar Jul 15 '25 17:07 pdjsh

@ligi I see people are also pinging you for approvals, sorry if I'm spamming, I would just like to know what needs to be done to get this merged and who can approve it. In case there's something incorrect about this I can take a look and fix it, just let me know

pdjsh avatar Jul 17 '25 17:07 pdjsh

@pdjsh I think your best bet here is to find a repo contributor to open a new HyperEVM PR so that all CI workflows are run. It seems that for a new contributors like myself this isn't the case, which results in the PR being ignored by the repo maintainers

ChiTimesChi avatar Jul 18 '25 08:07 ChiTimesChi

Yeah, I don't know what's wrong with what you did, I think everything is done as described in the contributing section of the readme. I'll try to maybe open an issue to discuss it, see if there's any activity there. Not sure how else to find a contributor. Apologies to you too if I spammed you, just trying to get this thing done

pdjsh avatar Jul 18 '25 11:07 pdjsh

This PR has no activity in a while - it will be closed soon.

github-actions[bot] avatar Aug 30 '25 02:08 github-actions[bot]