chains icon indicating copy to clipboard operation
chains copied to clipboard

Add ApeChain mainnet

Open MYKatz opened this issue 1 year ago • 7 comments

MYKatz avatar Oct 19 '24 22:10 MYKatz

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

github-actions[bot] avatar Oct 19 '24 22:10 github-actions[bot]

queenmoon-bot avatar Oct 20 '24 12:10 queenmoon-bot

@MYKatz might need to assign @ligi for review

kaisung avatar Oct 21 '24 21:10 kaisung

I don't think I have perms to add him as a reviewer on GH. @ligi can you please review?

MYKatz avatar Oct 21 '24 22:10 MYKatz

Hello! I am also interested in getting ApeChain on the chain list - I created a PR for it but then deleted it when I realized it was a duplicate of this one. @kaisung can you add @ligi as a reviewer? Thanks all! 🚀

joescherping avatar Oct 23 '24 04:10 joescherping

Hello! I am also interested in getting ApeChain on the chain list - I created a PR for it but then deleted it when I realized it was a duplicate of this one. @kaisung can you add @ligi as a reviewer? Thanks all! 🚀

@joescherping sorry I'm not a maintainer so can't add @ligi as reviewer but hoping they see this and can help review and merge soon.

kaisung avatar Oct 23 '24 04:10 kaisung

@ligi

Ramyromel avatar Oct 23 '24 04:10 Ramyromel

@ligi

joshuanwankwo avatar Oct 24 '24 04:10 joshuanwankwo

it's already appearing on chainlist but with different metadata: https://chainlist.org/?search=33139

joescherping avatar Oct 24 '24 16:10 joescherping

rebase the PR or allow me to rebase

ligi avatar Oct 24 '24 16:10 ligi

Apologies for that @ligi, just rebased.

MYKatz avatar Oct 24 '24 17:10 MYKatz

I guess this is a joke😅 @ligi

joshuanwankwo avatar Oct 25 '24 14:10 joshuanwankwo

@ligi We will sponsor this merge. Tx IDs are below. Please help merge in the next 24 hours. thanks https://etherscan.io/tx/0x59042d0c6833ac6099627b19a2ef749ce3ebfbea4d0fb15a54bc60f5eeb6cdec https://etherscan.io/tx/0x378e80bf65542888c7965c4ff93e5911d789e7e70dc8bf41ea227a762a2c5e9c

kaisung avatar Oct 25 '24 18:10 kaisung

PR merged - please consider contributing some funds to lists.eth

github-actions[bot] avatar Oct 25 '24 18:10 github-actions[bot]