seo icon indicating copy to clipboard operation
seo copied to clipboard

Focus keywords are wiped after upgrading to 4.0.0 and can't save new ones

Open MateuszEckardt opened this issue 2 years ago • 15 comments

Description

Hello,

I would like to mention that after updating plugin to v4.0.0 all focus keywords are wiped and you cannot add new ones. When providing a new keyword in the field, on enter it saves the entry but the keyword is not saved.

The only related issue I could find was Keywords in headless mode but I am not using Craft in headless mode, so I assume keywords should work.

I'd appreciate any feedback on this issue! Thanks

Steps to reproduce

  1. Create an entry OR edit an existing one
  2. Go to your SEO field, Optimisation tab
  3. Provide a keyword
  4. Click enter
  5. Entry saved
  6. Go back to the SEO field, Optimisation tab
  7. No keyword saved, empty field

Additional info

  • Craft version: 4.0.2 (pro)
  • SEO version: 4.0.0
  • PHP version: 8.1
  • Database driver & version: MYSQL 5.7.38
  • Other Plugins:

MateuszEckardt avatar May 20 '22 11:05 MateuszEckardt

I am experiencing the same. My best guess is that the entry form (maybe due to improved a11y?) submits when hitting enter before the keyword input can add the keyword.

There are 2 solutions here:

  1. The keyword input prevents form submission if it is focused.
  2. To create a keyword we use something different than the enter key.

I would prefer solution 1. Any idea how to do that?

rostockahoi avatar May 23 '22 12:05 rostockahoi

Experiencing the same issue. However, keywords are still showing in source code.

zadro avatar Jun 11 '22 02:06 zadro

Experiencing the same issue. Can we get an acknowledgement on this at least, please?

jakepm avatar Jun 12 '22 18:06 jakepm

Experiencing the same issue. Any updates on this please?

frederikvdbe avatar Jul 05 '22 08:07 frederikvdbe

I'm having the same issue. Getting "Entry Saved" when trying to add Keywords. Any ideas?

elyselindsays avatar Jul 11 '22 17:07 elyselindsays

Experiencing the same issue.

defser avatar Aug 12 '22 08:08 defser

We're taking a look into this one - I hope to come back to you all soon. Thanks for your patience.

alexjcollins avatar Aug 15 '22 10:08 alexjcollins

@alexjcollins Any news related this issue?

defser avatar Sep 01 '22 09:09 defser

There was an issue in the past when hitting enter it saved the entry, it's back again :)

The not saving part: Craft has a new way of auto-saving drafts, the submit is happening before the draft is saved so it won't save the keyword because that keyword didn't get "added" by then.

IMO making multiple options to add is the best way here.

  • TAB key
  • A physical button next to the input

kevinmu17 avatar Sep 01 '22 15:09 kevinmu17

Still no fix or update after 6 months...time to abandon this SEO plugin?

zadro avatar Nov 13 '22 16:11 zadro

@alexjcollins, this bug is becoming really painful for us. On the one hand, you've created an excellent lightweight plugin that many of our clients like, but on the other hand, we've been waiting so long for a fix now that some of our clients are getting frustrated and we are feeling pressured to abandon the plugin.

This is a core piece of the UX for the plugin, and there isn't even a workaround.

darwinsoftware avatar Dec 22 '22 16:12 darwinsoftware

@darwinsoftware

Relying on volunteers to maintain every open source project isn't long term sustainable. Funding open source projects could keep development moving. Maybe offer a small reward for a sollution or contribute yourself?

defser avatar Dec 22 '22 18:12 defser

Although you are certainly right @defser, this particular issue doesn't seem to be exactly easy to fix. That being said, it would be nice if we could at least get a hint on how to approach it.

Should we fix the input? For that we have to understand the implementation. I tried. (See my first comment)

Or should we replace the input with something else? Anyone knows a package or something that comes close to the current keyword input?

Finally, it would be nice if @alexjcollins could provide some insight if he could manage to invest more time into this issue if we provide a financial reward.

rostockahoi avatar Dec 23 '22 06:12 rostockahoi

@defser, of course, I agree with what you're saying, and I respect and appreciate that this plugin exists as an open-source project that is adding a lot of value to the Craft community.

That said, there has been no request for funding or help, and it seemed like this was in hand back in August. I would certainly be willing to contribute to a fund/reward to fix this bug, but I'd rather see a license fee added so that this valuable little plugin can justify improved support and maintenance.

darwinsoftware avatar Dec 23 '22 15:12 darwinsoftware

Finally, it would be nice if @alexjcollins could provide some insight if he could manage to invest more time into this issue if we provide a financial reward.

Willing to offer/contribute a fund to get this issue fixed. @alexjcollins ?

darwinsoftware avatar Mar 08 '23 17:03 darwinsoftware