etherpad-lite icon indicating copy to clipboard operation
etherpad-lite copied to clipboard

Building with submodule

Open thmo opened this issue 1 year ago • 4 comments

https://github.com/ether/etherpad-lite/blob/08f199178d2932cc0ec956aaeb3f62e8a535598a/Dockerfile#L116-L117

We are using etherpad-lite as a submodule, to build it in our CI with a given list of plugins. Being checked out as a submodule, there is no .git directory in the etherpad-lite directory, so these two lines will fail.

IIUC, this is used to allow running git inside the image to find out the version of etherpad - would it be possible to pass to skip this and e.g., set the version statically?

thmo avatar Sep 14 '24 08:09 thmo

Hm, #6495 should have fixed this, but it doesn't seem to work for buildah build-using-dockerfile. Any idea?

thmo avatar Sep 14 '24 08:09 thmo

Sorry no idea. I don't use buildah just docker itself.

SamTV12345 avatar Sep 16 '24 16:09 SamTV12345

See https://github.com/containers/buildah/issues/5742.

thmo avatar Sep 19 '24 06:09 thmo