etherpad-lite icon indicating copy to clipboard operation
etherpad-lite copied to clipboard

the BUG of font_family v0.5.44

Open kenzhu opened this issue 10 months ago • 4 comments

OS: Window 10 etherpad-lite version: 2.0.1 font_family version: 0.5.44

BUG description: the word's style can not change.

Steps to reproduce the behavior:

  1. select the words.
  2. click the "Font Family" selection to change the word's style.
  3. click the "Font Family" selection to change the word's style a second time.
  4. the word's style would not change.

kenzhu avatar Apr 08 '24 07:04 kenzhu

Thanks for the bug report. This is indeed a bug and I could reproduce this.

SamTV12345 avatar Apr 13 '24 08:04 SamTV12345

can confirm that this is still ongoing on etherpad-lite 2.1.0

manosKas avatar Jun 04 '24 13:06 manosKas

@SamTV12345

I’m not sure if this helps, but I found that on the Etherpad instance at https://demo.sandstorm.io/ the font changes correctly.

After exporting the pad from there, I checked the logs and found the following versions: Etherpad 1.8.18 (d5fd8e4) and ep_font_family 0.5.42.

I then tested it on my local instance using Etherpad 2.1.1 with [email protected] instead of [email protected], but the bug still persists.

Further investigation revealed that no matter what you do, selecting a font results in the same issue as placing the selected text into the following:

<span class="fontarial fontavant-garde fontbookman fontcalibri fontcourier fontgaramond fonthelvetica fontmonospace fontpalatino fonttimes-new-roman">
  <fontarial>
    <fontavant-garde>
      <fontbookman>
        <fontcalibri>
          <fontcourier>
            <fontgaramond>
              <fonthelvetica>
                <fontmonospace>
                  <fontpalatino>
                    <fonttimes-new-roman>
                      Etherpad
                    </fonttimes-new-roman>
                  </fontpalatino>
                </fontmonospace>
              </fonthelvetica>
            </fontgaramond>
          </fontcourier>
        </fontcalibri>
      </fontbookman>
    </fontavant-garde>
  </fontarial>
</span>

i guess the issue is in the etherpad side.

I’m trying to find a workaround until an official fix is released. If anyone can help, it would be greatly appreciated.

manosKas avatar Aug 07 '24 13:08 manosKas

@SamTV12345

I’m not sure if this helps, but I found that on the Etherpad instance at https://demo.sandstorm.io/ the font changes correctly.

After exporting the pad from there, I checked the logs and found the following versions: Etherpad 1.8.18 (d5fd8e4) and ep_font_family 0.5.42.

I then tested it on my local instance using Etherpad 2.1.1 with [email protected] instead of [email protected], but the bug still persists.

Further investigation revealed that no matter what you do, selecting a font results in the same issue as placing the selected text into the following:

<span class="fontarial fontavant-garde fontbookman fontcalibri fontcourier fontgaramond fonthelvetica fontmonospace fontpalatino fonttimes-new-roman">
  <fontarial>
    <fontavant-garde>
      <fontbookman>
        <fontcalibri>
          <fontcourier>
            <fontgaramond>
              <fonthelvetica>
                <fontmonospace>
                  <fontpalatino>
                    <fonttimes-new-roman>
                      Etherpad
                    </fonttimes-new-roman>
                  </fontpalatino>
                </fontmonospace>
              </fonthelvetica>
            </fontgaramond>
          </fontcourier>
        </fontcalibri>
      </fontbookman>
    </fontavant-garde>
  </fontarial>
</span>

i guess the issue is in the etherpad side.

I’m trying to find a workaround until an official fix is released. If anyone can help, it would be greatly appreciated.

Thanks for the testing. I'll have a look when I'm ready for this. Haven't really worked with the core editor itself a lot @Gared Do you have some experience where this can come from?

SamTV12345 avatar Aug 18 '24 08:08 SamTV12345