etherpad-lite icon indicating copy to clipboard operation
etherpad-lite copied to clipboard

Feature Request: case-insensitive pad names

Open fwolfst opened this issue 5 years ago • 8 comments

It would be great if a setting would allow the use of case-insensitive pad names (overview -> oVErvieW). Having etherpad deployed in a German environment where nouns are written capitalized, this lead to some confusion of users (some capitalize the pad name, others dont).

Currently, i work around that with some nasty nginx-rule (because not all request should be lowercased, some javascript assets use capital letters).

I am not a JavaScript-person and do not know the EP codebase but would assume that this is a rather low-hanging fruit (but then I don't know if the code is structured such that plugins etc just use the API which would respect the lowercase-setting).

Probably related: https://github.com/ether/etherpad-lite/issues/2557

fwolfst avatar Apr 07 '20 10:04 fwolfst

Etherpad already does

http://video.etherpad.com/p/blah https://video.etherpad.com/p/blaH

You just need to use MySQL or some sort of database that supports case sensitive database. :)

https://github.com/ether/etherpad-lite/wiki/How-to-use-Etherpad-Lite-with-MySQL

JohnMcLear avatar Apr 07 '20 19:04 JohnMcLear

Previous comment pointed out: https://github.com/ether/etherpad-lite/blob/79406051fa6610690f7c5ae1d6a0c79dc37f8a78/src/node/db/PadManager.js#L78 as a place to look at. You mean I would need case insensitive database, right? I have seen that actually some people did use a mysql-feature to do that.

My wish would be that I can tell etherpad that case does not matter.

http://video.etherpad.com/p/blah https://video.etherpad.com/p/blaH

Exactly. Thats my problem!

fwolfst avatar Apr 07 '20 19:04 fwolfst

Yes, make your database key case insensitive.

Or just add .toLower() on a pad Id anywhere in hooks/express/padurlsanitize.js.

I'm not sure I'm gonna write code/test coverage etc. for it tho! I can re-open and if enough people want it I will do it.

That's defo a weird feature request! Users are weird 💃

JohnMcLear avatar Apr 07 '20 19:04 JohnMcLear

Yes users are weird :)

otoh its not such a weird expectancy that URLs are handled case-insensitive ... like hTTPs://EtHeRPAd.oRG should work fine. Yep, I know why, but tell this an ordinary user. Also, the etherpad blog does not care about capitalization ( https://blog.etherpad.org/2020/03/17/Video-CHAT-with-etHErpAd/). I don't want to argue, but its not uncommon that URLs are treated as-if case-insentitive (same for email-adresses). Did somebody ever tell you the case of a letter when telling you a domain or an URL?

On Tue, Apr 7, 2020 at 9:21 PM John McLear [email protected] wrote:

Yes, make your database key case insensitive.

Or just add .toLower() on a pad Id anywhere in hooks/express/padurlsanitize.js.

I'm not sure I'm gonna write code/test coverage etc. for it tho! I can re-open and if enough people want it I will do it.

That's defo a weird feature request! Users are weird 💃

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ether/etherpad-lite/issues/3844#issuecomment-610573582, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABVR3KF3MAKBK7N225SKATRLN4L3ANCNFSM4MC7JHCQ .

fwolfst avatar Apr 07 '20 19:04 fwolfst

I would greatly support this being implemented. For me there is no reason to allow case sensitive rooms: What's the benefit? On the Con Side users are confused and it may not work with other systems that are case insensitive (e.g. Jitsi)

DanielHabenicht avatar Apr 08 '22 08:04 DanielHabenicht

Also as of today, there is no way to make it case-insentive anymore. ueberDB forces binary encoding which is case sensitive: https://github.com/ether/ueberDB/blob/7bef202597018bb2966f9f1fd00931760eb6b979/databases/mysql_db.js#L58-L62

I can add a Pull Request for adding a settings to make it case insensitive, if thats alright? @JohnMcLear

DanielHabenicht avatar Apr 08 '22 09:04 DanielHabenicht

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 11 '22 03:06 stale[bot]

I have a pr ready so we can get it fixed!

DanielHabenicht avatar Jun 11 '22 12:06 DanielHabenicht