etherpad-lite icon indicating copy to clipboard operation
etherpad-lite copied to clipboard

Some API endpoints change data with GET rather than POST

Open Miserlou opened this issue 12 years ago • 13 comments

This is poor API design as it introduces a potential security vulnerability.

I'd suggest this be changed some time in the future, but not without a heads up as it will break all of the client libraries. :(

Miserlou avatar Feb 13 '13 19:02 Miserlou

Also the API isn't RESTful so it's all over the place, it's a design mistake we made early on..

JohnMcLear avatar Feb 13 '13 19:02 JohnMcLear

@anttiviljami -- Any chance #3786 could resolve this please?

JohnMcLear avatar Mar 30 '20 14:03 JohnMcLear

I mean sure, but it would be a major breaking API change.

anttiviljami avatar Mar 30 '20 14:03 anttiviljami

I would probably just extract the current OpenAPI definition, modify it to create a new properly designed, restful version of the API and just expose it as a new major API version while supporting the old API for a while. Would be easy to do with openapi-backend

anttiviljami avatar Mar 30 '20 14:03 anttiviljami

+1 will be a 1.9 thing :)

JohnMcLear avatar Mar 31 '20 18:03 JohnMcLear

@anttiviljami was it possible for you to send through a PR including this breaking change please?

JohnMcLear avatar Mar 15 '21 16:03 JohnMcLear

Sorry @JohnMcLear. Too busy right now for pro bono work :(

anttiviljami avatar Mar 17 '21 10:03 anttiviljami