etherpad-lite
etherpad-lite copied to clipboard
Some API endpoints change data with GET rather than POST
This is poor API design as it introduces a potential security vulnerability.
I'd suggest this be changed some time in the future, but not without a heads up as it will break all of the client libraries. :(
Also the API isn't RESTful so it's all over the place, it's a design mistake we made early on..
@anttiviljami -- Any chance #3786 could resolve this please?
I mean sure, but it would be a major breaking API change.
I would probably just extract the current OpenAPI definition, modify it to create a new properly designed, restful version of the API and just expose it as a new major API version while supporting the old API for a while. Would be easy to do with openapi-backend
+1 will be a 1.9 thing :)
@anttiviljami was it possible for you to send through a PR including this breaking change please?
Sorry @JohnMcLear. Too busy right now for pro bono work :(