ep_comments_page icon indicating copy to clipboard operation
ep_comments_page copied to clipboard

Published 20 hours ago • verified publisher icon ether

Fix popup positioning, add response message to API calls for etherpad-lite-client to work

Open ilmartyrk opened this issue 3 years ago • 5 comments

The positioning of inline comment input form would go out of view when text is on the left side of document, added check to see if popup is out of view and if is then position is set to fit in view. Etherpad-lite-client expects OK response to include message, added the message part

ilmartyrk avatar Sep 09 '21 12:09 ilmartyrk

Apologies, I just noticed this PR. Please rebase onto latest main.

rhansen avatar Dec 20 '21 05:12 rhansen

@JohnMcLear Could be interesting to review and merge this.

SamTV12345 avatar Jul 03 '23 08:07 SamTV12345

@SamTV12345 it's 99% certain I wont get time to review each plugin. Sorry!

JohnMcLear avatar Jul 03 '23 15:07 JohnMcLear

No problem. I could test it. But I don't have write access to this and most of the other plugin repositories. No idea why because I'm in every team.

SamTV12345 avatar Jul 03 '23 16:07 SamTV12345

@ilmartyrk Could you please rebase?

SamTV12345 avatar Aug 09 '23 16:08 SamTV12345