ep_comments_page icon indicating copy to clipboard operation
ep_comments_page copied to clipboard

Comment popup is not displayed correctly on some mobile devices

Open tim-krieger opened this issue 3 years ago • 4 comments

Popup on my iPad (2019), Safari mobile, recent version of ep_comments_page, etherpad 1.8.12:

image

tim-krieger avatar Mar 08 '21 23:03 tim-krieger

@seballot any idea how this can happen?

JohnMcLear avatar Mar 08 '21 23:03 JohnMcLear

Yep : https://github.com/ether/ep_comments_page/blob/master/static/js/newComment.js#L85

The popup is aligned with comment icon, which does not work when comment icon is closed to the right border of the screen. Should be easy fix

seballot avatar Mar 09 '21 07:03 seballot

I think my iPad is not recognized as media only screen (800px). In web inspector the popup is displayed correctly. Should this be fixed in ether/etherpad-lite? It also infects other plugins with toolbar popups like ep_embedded_hyperlinks2. image

tim-krieger avatar Jul 08 '21 05:07 tim-krieger

If I use max-width 992px instead of 800px in popup.css (etherpad-lite) the new comment popup is diplayed correctly (iPad 2020).

tim-krieger avatar Jul 08 '21 16:07 tim-krieger