Han icon indicating copy to clipboard operation
Han copied to clipboard

The use of .scss format

Open ethantw opened this issue 10 years ago • 2 comments

Han.css is developed using .sass format in most cases for its conciseness. From v3.1.0, where we started using Gulp for development, the main files (src/sass/han.scss and index.scss) switched to .scss format since the module gulp-sass fails to compile .sass files correctly. Will switch back once the bug is fixed.

ethantw avatar Jan 08 '15 10:01 ethantw

Doesn't writing Han.css in SCSS better than writing it in SASS? Because SCSS is closer to CSS, doesn't this make new contributors unfamiliar with SASS or SCSS easier to contribute?

ys-chung avatar Aug 10 '15 08:08 ys-chung

My opinion is that there are hundreds of languages using indentation instead of curly brackets to delimit ranges. I don’t see why we shouldn’t use the Sass format. It is cleaner to look at and easier to write. That’s just a matter of preference. :smile:

FYI, the SCSS format is used in some cases in the project, such as listing font-family. https://github.com/ethantw/Han/blob/master/src/sass/typography/ff/_biaodian.scss

ethantw avatar Aug 10 '15 09:08 ethantw