react-image-magnify icon indicating copy to clipboard operation
react-image-magnify copied to clipboard

Update componentWillReceiveProps

Open lhtdesignde opened this issue 4 years ago • 4 comments

This lifecycle function is deprecated. Would be great if you could add UNSAFE prefix or generally refactor it to componentDidUpdate.

Warning: componentWillReceiveProps has been renamed, and is not recommended for use.
See https://fb.me/react-unsafe-component-lifecycles for details.
* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps.
Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work.
To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.
Please update the following components: EnlargedImage

Thanks!

lhtdesignde avatar Oct 30 '19 15:10 lhtdesignde

Actually I think this will break completely in react 17 since those methods can then only be called with the unsafe_ name.

ceisele-r avatar Feb 19 '20 12:02 ceisele-r

Hello @ethanselzer, Thank you for the nice library.

Do we expect any update regarding this warning soon ?

hiahmedhameed avatar May 28 '20 20:05 hiahmedhameed

Version of react-image-magnify: 2.7.4

  console.warn
    Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

    * Move data fetching code or side effects to componentDidUpdate.
    * If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
    * Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

    Please update the following components: ReactCursorPosition

spasticninja avatar Aug 24 '20 19:08 spasticninja

Issue still here, probably we need to make a fork

a-tonchev avatar Nov 04 '20 13:11 a-tonchev