react-cursor-position icon indicating copy to clipboard operation
react-cursor-position copied to clipboard

Published 20 hours ago • verified publisher icon ethanselzer

Fixing an issue with missing propTypes

Open Coriou opened this issue 4 years ago • 6 comments

Don't really understand the issue, but this fixes #35 by:

  1. providing an empty object to Object.keys as a default
  2. only emitting the event when there's actually something to send along with it

This fixes an issue I was having with another component using this one (ethanselzer/react-image-magnify)

Coriou avatar Jul 27 '20 15:07 Coriou

Coverage Status

Coverage remained the same at 100.0% when pulling e2fd02c9ff71236518382ce555bbf38660e3e540 on Coriou:fix-missing-props into 0f594bb6f08e774c68ef131d883ece1a55823ad0 on ethanselzer:master.

coveralls avatar Jul 27 '20 15:07 coveralls

I have tested the PR and it solves the issue. Please merge!

vincentdesmares avatar Jul 28 '20 08:07 vincentdesmares

@ethanselzer when can we expect this PR to be merged as this is a blockage in our production deployment, so knowing an expected time we can plan accordingly.

jsingh0026 avatar Aug 03 '20 05:08 jsingh0026

@ethanselzer @jacekradko can anybody merge this PR?

sandro768 avatar Sep 16 '20 09:09 sandro768

To anyone having issues with this library, I have found this alternative which seems to work well: laurenashpole/react-inner-image-zoom

Coriou avatar Oct 12 '20 09:10 Coriou

@ethanselzer @jacekradko can anybody merge this PR, please?

juanpallares avatar Oct 13 '20 09:10 juanpallares