json-api icon indicating copy to clipboard operation
json-api copied to clipboard

Published 20 hours ago • verified publisher icon ethanresnick

Add beforeDelete transform

Open carlbennettnz opened this issue 10 years ago • 7 comments

Closes #66

I gave the integration tests a shot, but the first one breaks another test and the second doesn't work at all. How should I be doing this?

carlbennettnz avatar Aug 30 '15 23:08 carlbennettnz

Thanks! I don't have much time tonight, but I'll take a look at this tomorrow and let you know.

ethanresnick avatar Aug 31 '15 02:08 ethanresnick

No problem

carlbennettnz avatar Aug 31 '15 02:08 carlbennettnz

Well the tests pass for me locally :/

carlbennettnz avatar Sep 07 '15 23:09 carlbennettnz

I still can't reproduce the problem Circle's facing. If you run these tests locally, do they pass for you?

carlbennettnz avatar Sep 10 '15 20:09 carlbennettnz

Any chance we could get this fixed and merged within the next few days? I'm almost ready to switch my company's app over to JSON API and I would rather use an official version of this library if possible.

carlbennettnz avatar Sep 15 '15 23:09 carlbennettnz

I'm almost ready to switch my company's app over to JSON API

Awesome!

Any chance we could get this fixed and merged within the next few days?

I'll take a look at it later this week or over the weekend. Basically, this hasnt beee merged yet only because it feels like we need to solve #28 first, and better account for all the different types of delete requests.

ethanresnick avatar Sep 16 '15 04:09 ethanresnick

Any update on this?

carlbennettnz avatar Oct 01 '15 00:10 carlbennettnz