phin icon indicating copy to clipboard operation
phin copied to clipboard

Published 20 hours ago • verified publisher icon ethanent

Contribution Guide

Open ktalebian opened this issue 4 years ago • 1 comments

Hello, I was going to open a PR for both phin and centra and add a few improvements:

  • Replace forEach with for-loop for performance reasons
  • Remove unnecessary else
  • Use of const over let
  • Migrate to use TypeScript

Is there a contribution guide or should I just open a PR and put it up for review? Also, I've noticed the codebase does not use any linter. Any interest in adding one?

ktalebian avatar Jun 28 '20 19:06 ktalebian

Thanks for the suggestions. Sure, adding a linter could be helpful. I'm not really able to experiment with that too much right now, so a PR would be very much appreciated.

ethan7g avatar Nov 01 '20 21:11 ethan7g