Ethan Chiu
Ethan Chiu
@gjergjk71 can you copy and paste the error here?
@gjergjk71 could you open a pull request or copy and paste the code here so that I can debug it out myself?
I don't think @gjergjk71 is working on this anymore. Feel free to start on this PR and break it down into multiple steps by opening seperate, smaller PR's! Thanks!
Added comments. Also, food for thought, can we test the following methods as well? - evaluate_pylint => can we check that a temp file was created? - test socket io...
Also, are you interested in writing the JS unit tests as well? If not, that's totally fine!
Sounds good!
@dgmouris Can you check out the work that @chaps did over here: https://github.com/ethanchewy/PythonBuddy/pull/52, https://github.com/ethanchewy/PythonBuddy/pull/53 I'll try to combine both of your commits together.
@dgmouris yeah, that would be great if you could review them!
@dgmouris sounds good - thanks so much! In general, for best practices, you should make your PR as small as possible. So, it's better to have multiple, smaller PR's instead...
@dgmouris that sounds good to me! Sorry I have to finish a few deadlines for my school commitments but I should be able to review and merge your PR's within...