dart_eval icon indicating copy to clipboard operation
dart_eval copied to clipboard

Add support for Sets

Open ethanblake4 opened this issue 3 years ago • 4 comments

This will need: Support in the parser (parser.dart) A new EvalSet type in primitives.dart A new DartSetLiteral class in literals.dart ???

ethanblake4 avatar May 11 '21 16:05 ethanblake4

Hi, are the points above still applicable? I'm planning to contribute and think that sets would be a good start.

wrbl606 avatar Oct 12 '23 19:10 wrbl606

Ah not really, this issue is quite old. For Sets, you'd probably need to:

To be frank this is slightly complicated for a first issue at this point since it touches all three parts of dart_eval (compiler, standard library, and runtime). It is doable but I might suggest #4 or #91 first. (Thanks for your interest in contributing btw!)

ethanblake4 avatar Oct 12 '23 20:10 ethanblake4

You're right, I thought that it'll be easier to do (somehow) 😀 Thanks for the explanation!

wrbl606 avatar Oct 13 '23 05:10 wrbl606

Hi, @ethanblake4 i can do the 2 and 3 points you said.

The 1st and 4th are just beyond me. If you could elaborate just on them 🙏🙏 it would be big help.

Noobware1 avatar Nov 08 '23 18:11 Noobware1