brownie icon indicating copy to clipboard operation
brownie copied to clipboard

Published 20 hours ago • verified publisher icon eth-brownie

Add metadata output to a build JSON

Open bakatrouble opened this issue 3 years ago • 3 comments

What I did

Added a metadata output to solc which is needed for Sourcify and IPFS source verification

Related issue: #931

How I did it

Changed solc call parameters

How to verify it

Build JSONs in build/contracts/ after compilation now contain a string property metadata

Checklist

  • [x] I have confirmed that my PR passes all linting checks
  • [ ] I have included test cases
  • [ ] I have updated the documentation
  • [ ] I have added an entry to the changelog

How do I proceed with the rest of the checklist points, if needed?

bakatrouble avatar Oct 07 '21 12:10 bakatrouble

can we please land this soon? need this to verify contracts on sourcify.

sfc-gh-dwu avatar Nov 24 '21 22:11 sfc-gh-dwu

emitting the standard solc metadata output is necessary for a lot of tooling. What's blocking this PR to be merged/taken over? (appart for some basic cleanup?)

joaquim-verges avatar Jun 22 '22 03:06 joaquim-verges

Any updates about this? By mistake I created also another PR. But I think I will remove mine because it seems like this is more active. At Sourcify (EF) we have an issue to track this https://github.com/ethereum/sourcify/issues/804

If anyone can tell me what is needed in order to merge this PR I can work on it, I'm not an expert python developer, but I think I can sort it out.

marcocastignoli avatar Oct 26 '22 16:10 marcocastignoli