android icon indicating copy to clipboard operation
android copied to clipboard

Dark mode support

Open lokesh-krishna opened this issue 3 years ago • 14 comments

I'm sorry if I'm missing something but I did check and I can't find a dark mode option in the Android client.
Could you please consider adding support for dark mode?

lokesh-krishna avatar Nov 01 '20 14:11 lokesh-krishna

Hey, we definitely want to add a dark mode at some point, though since this app is generally mostly used in the background (I rarely open the app myself, for example), it's less of a priority. The EteSync Notes app however, does support dark mode!

tasn avatar Nov 01 '20 14:11 tasn

Because Android 12 shall handle visual customisation very differently to its predecessors, now is when you should rewrite the interface of EteSync to support features such as dark mode.

RokeJulianLockhart avatar Sep 07 '21 23:09 RokeJulianLockhart

Oh, got more info about Android 12 visual customizations?

tasn avatar Sep 09 '21 21:09 tasn

http://github.com/etesync/android/issues/144#issuecomment-916435925.

@tasn, interfaces that shall be designed for Android 12 shall use new methodology for interface-design. The implementation of this methodology is being referred to collectively as Material You. It is one much more adaptive iteration of Material Design. Comparatively, the appearance of EteSync is appearing to be quite unadaptive, especially because it lacking any form of darkness for the interface of it.

RokeJulianLockhart avatar Sep 10 '21 16:09 RokeJulianLockhart

Yeah, I saw the announcement, thanks!

It probably requires rewriting the whole UI, and I'm not sure it's a good investment given that people don't actually use the app under normal circumstances. It's intended to be run in the background.

tasn avatar Oct 22 '21 10:10 tasn

http://github.com/etesync/android/issues/144#issuecomment-949506970.

@tasn, the interface of EteSync should not be very complicated because most operation is handled by its web-technology-based counterpart. Consequently, this may be the perfect opportunity to support dark-mode with minimal effort, because although my knowledge of development of software for Android is very limited, the automatic adaptation that is inherent to the redesign should allow for support of dark-mode without creation of a separate dark interface, which I am quite confident that continued usage of the current iteration of the framework would require.

RokeJulianLockhart avatar Oct 22 '21 10:10 RokeJulianLockhart

Yeah, it will support dark mode, but again it's a lot of work for an app that's always in the backrgound.

EteSync Notes - which users actually use, supported dark mode almost from the start!

tasn avatar Oct 22 '21 11:10 tasn

While it's true that one rarely launches the app after the initial setup, one shouldn't underestimate the impact of a first impression. As the app grows increasingly distant from Android's present design language, it is going to look outdated even when it's not and that's not a good first impression.

It's also true that the mobile design language scene keeps moving but this has been the biggest redesign in a while and targeting this should mean we should be good for the next couple of years.

lokesh-krishna avatar Oct 22 '21 11:10 lokesh-krishna

Not underestimating the impact, it's just a lot of work (I think). I'd be VERY happy to have it, I'm just not sure I can commit to making it happen.

tasn avatar Oct 22 '21 11:10 tasn

I have implemented dark mode support for this app.

jahway603 avatar Dec 07 '21 05:12 jahway603

Has the improvement been submitted to http://f-droid.org ?

RokeJulianLockhart avatar Dec 12 '21 16:12 RokeJulianLockhart

I reviewed the patch, just want a few quick fixes and we can release a new version!

Thanks a lot @jahway603 !

tasn avatar Dec 31 '21 10:12 tasn

Just wondering, did this ever get pushed out?

Latest version is from Sep this year and the comment above is Dec 2021.

madindehead avatar Nov 17 '22 19:11 madindehead

There were still pending comments I believe, as in, it wasn't working correctly.

tasn avatar Nov 18 '22 22:11 tasn