Sandcastle-Builder
Sandcastle-Builder copied to clipboard
eternaldensity
Favourites Manager and Unbought/Locked Items
Favourites Manager allows you to save boosts as faves even when they're not unlocked or are unlocked but in the shop. This is great but it causes problems with Molpy.Draw.
I believe the boost gets drawn even when it's not owned, which in the case of Muse causes it to try to do math with null values if the current NP doesn't have any dragons (freeze crashes the game). It also causes weird scrolling issues when you have a favourited boost unlocked but not bought.
I have tried my damnedest to get this to crash the game, but I can't. I favorited Muse in both group and pane style, and tried drawing it on positive and negative NP with and without discoveries, but Muse never threw an error. Muse remains grayed-out in both the favorites manager group and favorites pane. Has something changed since this issue was posted? At any rate, I can replicate the weird scrolling, but I don't know where I'd start with that.
If it's visible in the favorites pane, it says "This boost is locked!" and all is well. However, if you're on an NP with a discovery you can't make a masterpiece of yet, the favorites group version will tell you how much it costs, and if you're on a NP without a discovery, it will remain blank. Neither of these crashes the game for me, and both are fixed by a simple if (!me.bought) that I've committed. It seems like this should fix the crash, too, since no math is done in that case, but I can't be sure since it doesn't crash in the first place.
I would like to get to the bottom of this one, because I have a suspicion it's related to why, in my main save file, the game does not like to remember my selected (pane) favorites on page reload. Often they are all reset to blank, usually when I have made layout changes. It's probably due to the fact that, for whatever weird reason, I have a collection of locked boosts (Jamming, Glass Blower Switching, Constructing from Blackprints, &c.) favorited. I never realized that might be why I have so much trouble keeping them saved.
There's a save that crashes consistently (for me at least) here: http://pasted.co/8e381175
Thanks! It successfully crashes for me too, unless the new Muse description is implemented. Now that just leaves the wonky scrolling. I'll investigate whether other boosts need locked descriptions, but I'm not sure what I can do about the scrolling.