Sandcastle-Builder
Sandcastle-Builder copied to clipboard
eternaldensity
GitHub Pull Request Discussion
Not sure where else to put this.
I'm still unfamiliar with github. I created two different pull requests for the same file, but two different issues. One is a simple description update that I was requested to make (didn't notice I even had an inbox until today), and the other is a much more in-depth change to Panther Rush. Should I have kept them both in the same pull request, or was this the right way to do it?
Additionally, is there any way to test these changes before they go live, other than using something like Firebug to edit the code on the page as it is running? I know Firebug can do that, but I haven't tried it yet.
I'm not certain about the pull requests.
To test what you have made. The file is castle.html or classic.html depending on which you normally use.
If you are working from Git, you can run the local copy in your web browser.
If you are working from Github I think you must either clone a local copy or download the project as a zip file and it should be possible to run that.
Looks like they can both be implemented without affecting each other, assuming they are not affecting the same chunk of code of course.