edb-debugger icon indicating copy to clipboard operation
edb-debugger copied to clipboard

The syntax highlighter is a bit naive

Open eteran opened this issue 8 years ago • 1 comments

The syntax highlighter works well, but is a little naive, for example when highlighting a symbol such as:

libasm-0.163.so!__x86.get_pc_thunk.bx

the 0.163 is highlighted as a numeric value and the bx is highlighted as a register. We should probably add a little bit of context awareness to the highlighter to make it get these little details correct.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

eteran avatar May 18 '16 04:05 eteran

It's indeed naive and doesn't work well in some cases, but it's also quite slow. It seems it should be done in some other way than using regexp, although I don't know what ways would those be. Maybe the instructions themselves should be drawn more "manually", i.e. mnemonic with separate highlighting, then operands, where symbolic addresses are already known to be present or not, etc.

10110111 avatar May 18 '16 05:05 10110111