c-vector icon indicating copy to clipboard operation
c-vector copied to clipboard

Update CMakeList for Windows build and CI test

Open TheTechsTech opened this issue 1 year ago • 2 comments

Great work!

I had a different vector construction setup, then came across your feature for regular array index access. I scraped/refactored my version in https://github.com/zelang-dev/c-raii/tree/main/src/vector.c to use yours exclusively, memory usage cleanup is automatic though, RAII.

There are a few ideas to make c-vector more expandable, like adding an enum type field to vector_metadata_t, macro to set/get.

TheTechsTech avatar Dec 21 '24 21:12 TheTechsTech

I'll take a look in a little bit! Thanks

eteran avatar Dec 22 '24 21:12 eteran

This generally looks good. Just as a heads up, another PR that also at least touches CMakeLists.txt came in literally just the day before you submitted yours. So we may need to rebase yours and resolve conflicts after I merge his. (Calling it a night tonight, but will probably try to merge both the other PR and yours tomorrow).

eteran avatar Dec 23 '24 05:12 eteran