core-geth icon indicating copy to clipboard operation
core-geth copied to clipboard

Merge/foundation release/1.13.5

Open meowsbits opened this issue 1 year ago • 5 comments

Rel #575, #563.

Merges https://github.com/ethereum/go-ethereum/releases/tag/v1.13.5.

meowsbits avatar Nov 30 '23 15:11 meowsbits

Not sure why lint and tests are failing, they pass for me locally.

meowsbits avatar Nov 30 '23 16:11 meowsbits

This branch is a superset of the 13.x branches:PRs below, with these stacked PRs originally intended only to piece-out the diffs for review's sake.

  • merge/foundation-release/1.13.4: https://github.com/etclabscore/core-geth/pull/575
  • merge/foundation-release/1.13.1: https://github.com/etclabscore/core-geth/pull/563

Those PRs have been reviewed and :heavy_check_mark:'d.

This branch has been merged with the latest versions of both those branches (as noops, but just to be safe), so I'm going to close those PRs in favor of this one. Then I'll change the base (/target) branch of this PR to master.

meowsbits avatar Feb 20 '24 19:02 meowsbits

Don't know why the "go generate check" is failing... can't reproduce locally.

meowsbits avatar Feb 20 '24 21:02 meowsbits

Gosh I just love green lights. Thanks @ziogaschr :green_heart:

meowsbits avatar Feb 21 '24 14:02 meowsbits

Syncing finished fine on all nodes @meowsbits. Let's merge it

ziogaschr avatar Mar 07 '24 07:03 ziogaschr