core-geth icon indicating copy to clipboard operation
core-geth copied to clipboard

refactor block reward calculators to params/

Open meowsbits opened this issue 5 years ago • 2 comments

Migrated from: https://github.com/etclabscore/multi-geth-fork/issues/66 Original author: @meowsbits


https://github.com/etclabscore/multi-geth/blob/feat/x-chainspec-types-and-tests/consensus/ethash/consensus.go#L547-L571

Logic should be in params/. The logic(s) are implementations of IP-defined parameters. And will keep keep all related logic centralized together.

rel #64

meowsbits avatar Feb 19 '20 16:02 meowsbits

to chain config or ethash config?

Ubiq migrated rewards to ethash config.

https://github.com/ubiq/go-ubiq/blob/master/params/config.go#L68 https://github.com/ubiq/go-ubiq/blob/master/consensus/ubqhash/consensus.go#L622

iquidus avatar Oct 26 '20 12:10 iquidus

@iquidus can we close this one?

ziogaschr avatar Jul 07 '21 15:07 ziogaschr