core-geth
core-geth copied to clipboard
etclabscore
make client classic first
Migrated from: https://github.com/etclabscore/multi-geth-fork/issues/153 Original author: @soc1c
renaming and releasing allows us for a breaking change we should consider:
- default chain should be classic (i.e., running without any flags)
- default testnet should be kotti (i.e., running --testnet)
Reiterating conversation from previous forum:
@meowsbits:
Doing this will require a Major version change. (https://semver.org/)
Eventually I want to decouple the program(s) from configuration defaults entirely.
But I see the reasoning for this now (since the project is largely supported by ETC-first backers), and think that if there's a time to do it, this seems like an OK one.
Noting also that we'll need to very careful with data directories...
Geth doesn't behave consistently or very predictably when managing FS structure with regard to -- settings (eg ethereum/go-ethereum#19172).
@soc1c:
Doing this will require a Major version change. (https://semver.org/)
We are already doing a major repository change. We are about to release a new client.
Releasing 1.10.0 would be sufficient. (Minor version change)
If we want to do some radical changes, let's not hesitate to do them now.
Because later will not happen
Releasing 1.10.0 would be sufficient. (Minor version change)
Can you provide your reasoning here?
Because later will not happen
Ditto... reasoning?
Wondering if this is still an issue I can help with? ( You could assign me if you want :) )
Hey, wow! thanks @cryptoasuka! At this point the question is primarily an API one. Changing default behavior is a BIG change, which makes me a little skittish on changing from one (inherited) opinion to another.
My preference would actually be to remove the ETH default, leaving no default, forcing the user to use some --<chain> flag.
Big +1 on no default behavior. As someone who runs a lot of core-geth nodes, I very much prefer changes that things break things immediately and loudly (like having no default chain) so that I'm never caught with something broken that I think works.
any preferences on flag naming for ethereum mainnet? --ethereum or --foundation ?
edit: faucet already uses 'foundation', will stick with this.
update: staying inline with recent upstream additions, --mainnet will be used for ethereum mainnet.
initial phase (no chain flag warn) has begun, see: https://github.com/etclabscore/core-geth/pull/319