phabulous icon indicating copy to clipboard operation
phabulous copied to clipboard

Add custom UnmarshalJSON methods for modified conduit api responses

Open schleppy opened this issue 6 years ago • 1 comments

Add custom UnmarshalJSON methods for DifferentialRevision and DifferentialQueryRequest to handle change in reviewers type from []string to map[string]string in conduit api. Each value in the map is the same as the key, so we just need to read the keys

schleppy avatar Jun 14 '18 18:06 schleppy

Codecov Report

Merging #70 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   20.32%   20.32%           
=======================================
  Files          25       25           
  Lines         925      925           
=======================================
  Hits          188      188           
  Misses        735      735           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f8cd00...52823d8. Read the comment docs.

codecov[bot] avatar Jun 14 '18 18:06 codecov[bot]