phabulous icon indicating copy to clipboard operation
phabulous copied to clipboard

Published 20 hours ago • verified publisher icon etcinit

Update version strings

Open etcinit opened this issue 8 years ago • 4 comments

Figure out a better way of including the version in the binary. Currently, it is being hardcoded in a couple of places.

etcinit avatar Feb 20 '17 03:02 etcinit

perhaps related to this, im not sure, is that the latest release 3.0.0-beta1 returns as if it was version 2.4.0 but the bot announces itself as if it was version 3

curl http://localhost:8085/
{"messages":["Welcome to the Phabulous API"],"status":"success","version":"2.4.0-beta1"}

perrohunter avatar Feb 20 '17 20:02 perrohunter

Yep. Looking to find a simple way to have it centralized in one place.

etcinit avatar Feb 21 '17 19:02 etcinit

I am also affected by this with the v3.0.0-beta3 tag on quay.io.

holmboe avatar Apr 23 '18 08:04 holmboe

It is better to hardcode something like UNKNOWN in front.go, no? If tit is not guaranteed to be correct and updated then I suggest that it would be better.

holmboe avatar Apr 23 '18 08:04 holmboe