phabulous icon indicating copy to clipboard operation
phabulous copied to clipboard

Tasks with multiple projects get routed improperly

Open AtomicTroop opened this issue 9 years ago • 5 comments

We tag each task with a project tag and a type tag (using project tags), so an average task might have the project tags #someexampleproject and #code. We've set phabulous to route notifications about tasks with the #someexampleproject tag to a certain slack channel. These never arrive if the tasks includes any other tags.

To summarize, phabulous seems to assume the tag rule to be this tag and nothing else while I expect it to be at least this tag. Not sure if this is intentional.

AtomicTroop avatar Mar 01 '16 14:03 AtomicTroop

Minor addition, it seems some tasks do get posted to the slack channel, but only if the project tag is listed before the type tag. Interestingly, the order you add these tags to a new task doesn't seem to affect the order they are listed. We're still figuring out what situations and task add processes affect the tag order, but I don't think it should matter at all.

AtomicTroop avatar Mar 01 '16 15:03 AtomicTroop

Yeah, the bot currently only supports resolving one channel per object (task, repository, etc). This is definitely an issue when tagging something with multiple projects. I'll need to update resolver code to loop over every project attached to an object.

etcinit avatar Mar 03 '16 00:03 etcinit

i've got a fork here: https://github.com/blades/phabulous that addresses this in the maniphest resolver class if you're interested. i haven't touched any of the other resolvers, though.

blades avatar Sep 12 '17 12:09 blades

i've added a pull request, too. if i get a chance, i'll see if i can do anything further with the other resolvers if necessary.

blades avatar Sep 12 '17 12:09 blades

Somewhat related, tasks with no project tags cause Phabulous to send a message with just "(More Info)" to all channels being routed under projects: in main.yml it seems.

joelruns avatar Jul 21 '18 14:07 joelruns