phabulous icon indicating copy to clipboard operation
phabulous copied to clipboard

summons command does not validate to summon for a valid review

Open shivamb opened this issue 8 years ago • 2 comments

While summoning a reviewer to review for a task it does not pre-check if the reviewer has already reviewed a revision. In either cases if the reviewer has already accepted the revision, rejected or asked for a change the summon command summons the user.

shivamb avatar Jan 18 '16 10:01 shivamb

Yes, the current functionality of the summon command is very basic. Future versions should consider this and some sort of Slack-to-Phabricator user mapping.

etcinit avatar Jan 20 '16 03:01 etcinit

I've begun work on this area. Currently, it seems Phabricator does not return individual reviewer status when querying for revisions. However, it does include the status of the revisions in general (Open, Closed, etc).

etcinit avatar Oct 17 '16 01:10 etcinit