zetcd icon indicating copy to clipboard operation
zetcd copied to clipboard

Issue98fix

Open hokie228 opened this issue 5 years ago • 5 comments

This fixes the encoding of a partial response to a multi-op request where one succeeds but another fails. The current implementation returns an error with no response, but Kafka expects Zookeeper to still respond with two results, one with a type of opCheck and another with type opError.

This patch allows it to response to each part of a multi-op request individually, using the first error in the list as the overall result. This fixes the NPE in Kafka described in Issue #98

hokie228 avatar Feb 28 '19 16:02 hokie228

Changes look OK; have you tried the cross-checked integration tests with go test -tags xchk,docker?

heyitsanthony avatar Feb 28 '19 19:02 heyitsanthony

I have also fixed the integration cross-check tests and implemented the Multi-op test. There are still some failures in the integration tests unrelated to the Multi-op changes than I will try to address later, but all the unit and integration tests pass now. I think everything is ready to go.

hokie228 avatar Mar 01 '19 21:03 hokie228

Any chance this can be merged soon?

F21 avatar Apr 10 '19 09:04 F21

@heyitsanthony ?

mickymiek avatar Jun 11 '19 09:06 mickymiek

@xiang90, can you look at merging this? It seems to have been silently dropped by the original maintainer...

arizvisa avatar Sep 04 '20 02:09 arizvisa