website icon indicating copy to clipboard operation
website copied to clipboard

Published 20 hours ago • verified publisher icon etcd-io

Add 3.6 downgrade instructions.

Open siyuanfoundation opened this issue 8 months ago • 6 comments
trafficstars

https://github.com/etcd-io/website/issues/960

siyuanfoundation avatar Feb 28 '25 20:02 siyuanfoundation

Thanks for the PR, @siyuanfoundation.

The v3.6 update guide link isn't working. I opened #966 to add a layout/placeholder so we can avoid these issues.

Could you please take a look at the linter issues? https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_website/965/pull-website-lint/1895572262531108864

Thanks again :)

ivanvc avatar Feb 28 '25 21:02 ivanvc

Could you move the downgrade_3.5 related change into a separate PR? It should can be approved & merged soon.

@fuweid can you please take a look at the downgrade_3.6 guide if you get time? thx

ahrtr avatar Mar 06 '25 14:03 ahrtr

Could you move the downgrade_3.5 related change into a separate PR? It should can be approved & merged soon.

3.5 changes in https://github.com/etcd-io/website/pull/970

siyuanfoundation avatar Mar 06 '25 21:03 siyuanfoundation

Thanks @ajaysundark for the careful review!

siyuanfoundation avatar Mar 11 '25 16:03 siyuanfoundation

/retest

jberkus avatar Mar 13 '25 18:03 jberkus

/retest

jberkus avatar May 02 '25 22:05 jberkus

/retest

I think the reason for the workflow failures is it depends on the other PR https://github.com/etcd-io/website/pull/967, which hasn't been merged yet.

ahrtr avatar May 03 '25 10:05 ahrtr

@siyuanfoundation pls rebase this PR. we just merged https://github.com/etcd-io/website/pull/967

ahrtr avatar May 08 '25 19:05 ahrtr

rebased. now all green

siyuanfoundation avatar May 08 '25 23:05 siyuanfoundation

Technically speaking, overall looks good to me, thanks for the great work!

Just a non-technical comments, the downgrade checklist ("difference in flags" and "Difference in Prometheus metrics") is almost identical to the upgrade guide. Should we just point users to the upgrade guide to avoid duplication?

cc @jberkus @spzala @jmhbnz

ahrtr avatar May 12 '25 09:05 ahrtr

Technically speaking, overall looks good to me, thanks for the great work!

Just a non-technical comments, the downgrade checklist ("difference in flags" and "Difference in Prometheus metrics") is almost identical to the upgrade guide. Should we just point users to the upgrade guide to avoid duplication?

cc @jberkus @spzala @jmhbnz

Thanks for checking @ahrtr !! Difference in Prometheus section is very small, so I think mentioning it in both docs is fine (as they are currently) vs pointing to Upgrade guide from this doc.

spzala avatar May 12 '25 15:05 spzala

Thanks for checking @ahrtr !! Difference in Prometheus section is very small, so I think mentioning it in both docs is fine (as they are currently) vs pointing to Upgrade guide from this doc.

OK, thx @spzala for the feedback.

@jberkus I think this PR is ready to merge, we can resolve the minor comment in a quick followup.

ahrtr avatar May 12 '25 16:05 ahrtr

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, siyuanfoundation, spzala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 12 '25 16:05 k8s-ci-robot