website icon indicating copy to clipboard operation
website copied to clipboard

add partial for version banner

Open moficodes opened this issue 1 year ago • 4 comments

  • add partial for version banner
  • add a version called latest in the version list

moficodes avatar Sep 20 '24 17:09 moficodes

@jmhbnz

moficodes avatar Sep 25 '24 00:09 moficodes

I am still seeing that v3.4 is showing up in the deploy preview as having the deprecation banner? https://deploy-preview-900--etcd.netlify.app/docs/v3.4/

v3.4 is still supported so should not have the banner, please let me know if I am missing something.

jmhbnz avatar Sep 25 '24 00:09 jmhbnz

There was is_deprecated flag set on 3.4 removed in the latest commit.

moficodes avatar Sep 25 '24 15:09 moficodes

This change looks good to me. One thing worth noting is that the v3.6 docs now show a warning, too. I think it should be fine, but I just wanted to raise awareness of it.

https://deploy-preview-900--etcd.netlify.app/docs/v3.6/

ivanvc avatar Sep 26 '24 17:09 ivanvc

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz, moficodes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 26 '24 18:09 k8s-ci-robot