website
website copied to clipboard
Create etcd_dash_dash_help_2to_conf.bash.sh
please be gentle
related issue #903
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: webdawg Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @webdawg. Thanks for your PR.
I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/ok-to-test
@ivanvc @jmhbnz @spzala defer to you on this one.
@webdawg
-
To pass the DCO check, you have to signoff your commit off all your commit to always include Signed-off-by: Author Name [email protected] in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
-
Could you please elaborate on the testing you have done to achive a successful execution of thi script and add it to the PR description ?
Also: this is the version of the script to create a config file. The one that belongs in /website should be the version that generates the output for configuration.md. They'd both be pretty similar -- or even one script with switches -- but that's what we need in this location.
@webdawg do you think you'll get back to this change?
So I need to move this to scripts for the project then? This script will output an optional configuration file into the etcd project. I would / could create an additional script to take that output, and insert it into configuration.md - it would be easier to have a second script because the conf style config example that is outputted is a closer match to the configuration.md.
How do I move this to a different project or do I start the pull request over?
Also can someone remind me of how I get this as part of a build trigger? What about tests?
Yes, you'll need to start a new PR because it'll be against /etcd-io/etcd.
I'd recommend asking for help on adding it to build etc. on #sig-etcd channel, or the etcd-dev mailing list, or in the Etcd community meeting.