raft
raft copied to clipboard
Optimise memory deallocation for stable log entries
Increment: Modify unstable.shrinkEntriesArray() to better account for underlying-array utilisation Fixes #71
hi @pavelkalinnikov, could you please review the PR? if it looks good then I'll get started on the "MemoryStorage.Compact method" as well that you had mentioned in the original issue
hi @pavelkalinnikov, does the PR need any changes?
hi @pavelkalinnikov, could you please review the PR?
@Aditya-Sood Sorry, been super busy recently. Will review this PR this week.
hi @pavelkalinnikov, could you please share your thoughts on this approach - https://github.com/etcd-io/raft/pull/96#discussion_r1327965688
hi @ahrtr, would you be able to weigh-in on https://github.com/etcd-io/raft/pull/96#discussion_r1327965688?
hi @mitake, @serathius, @ptabor, @spzala would you be able to share your opinion on https://github.com/etcd-io/raft/pull/96#discussion_r1327965688? I can start working on the change then, this PR has been open for 2.5 months now
hi @pav-kv
QQ for any optimisation, do we have a benchmark that confirms the improvement?
hi @serathius, no I haven't implemented the proposed change yet if you don't foresee any immediate issues with this approach then I can implement it and look into benchmarking?