raft icon indicating copy to clipboard operation
raft copied to clipboard

Optimise memory deallocation for stable log entries

Open Aditya-Sood opened this issue 1 year ago • 10 comments

Increment: Modify unstable.shrinkEntriesArray() to better account for underlying-array utilisation Fixes #71

Aditya-Sood avatar Aug 18 '23 12:08 Aditya-Sood

hi @pavelkalinnikov, could you please review the PR? if it looks good then I'll get started on the "MemoryStorage.Compact method" as well that you had mentioned in the original issue

Aditya-Sood avatar Aug 18 '23 12:08 Aditya-Sood

hi @pavelkalinnikov, does the PR need any changes?

Aditya-Sood avatar Aug 26 '23 19:08 Aditya-Sood

hi @pavelkalinnikov, could you please review the PR?

Aditya-Sood avatar Sep 10 '23 16:09 Aditya-Sood

@Aditya-Sood Sorry, been super busy recently. Will review this PR this week.

pav-kv avatar Sep 10 '23 20:09 pav-kv

hi @pavelkalinnikov, could you please share your thoughts on this approach - https://github.com/etcd-io/raft/pull/96#discussion_r1327965688

Aditya-Sood avatar Oct 13 '23 00:10 Aditya-Sood

hi @ahrtr, would you be able to weigh-in on https://github.com/etcd-io/raft/pull/96#discussion_r1327965688?

Aditya-Sood avatar Oct 24 '23 09:10 Aditya-Sood

hi @mitake, @serathius, @ptabor, @spzala would you be able to share your opinion on https://github.com/etcd-io/raft/pull/96#discussion_r1327965688? I can start working on the change then, this PR has been open for 2.5 months now

Aditya-Sood avatar Nov 03 '23 03:11 Aditya-Sood

hi @pav-kv

Aditya-Sood avatar Feb 14 '24 04:02 Aditya-Sood

QQ for any optimisation, do we have a benchmark that confirms the improvement?

serathius avatar Feb 14 '24 08:02 serathius

hi @serathius, no I haven't implemented the proposed change yet if you don't foresee any immediate issues with this approach then I can implement it and look into benchmarking?

Aditya-Sood avatar Feb 14 '24 09:02 Aditya-Sood