raft icon indicating copy to clipboard operation
raft copied to clipboard

refact JointConfig to To improve code understandability

Open zwkno1 opened this issue 9 months ago • 3 comments

zwkno1 avatar Mar 31 '25 15:03 zwkno1

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zwkno1 Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 31 '25 15:03 k8s-ci-robot

Hi @zwkno1. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Mar 31 '25 15:03 k8s-ci-robot

The refactor seems acceptable for merge as it was reasonable and trivial, and then I found errors.

serathius avatar Mar 31 '25 20:03 serathius