etcdctl: refactor global flags management and simplify command initialization
This PR is a part of: https://github.com/etcd-io/etcd/pull/20270
It prepares for subsequent unit testing.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hwdef Once this PR has been reviewed and has the lgtm label, please assign siyuanfoundation for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
:x: Patch coverage is 0% with 89 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 69.42%. Comparing base (7b1f0f2) to head (c85f68d).
:warning: Report is 4 commits behind head on main.
Additional details and impacted files
| Files with missing lines | Coverage Δ | |
|---|---|---|
| etcdctl/ctlv3/command/check.go | 0.00% <0.00%> (ø) |
|
| etcdctl/ctlv3/ctl.go | 0.00% <0.00%> (ø) |
|
| etcdctl/ctlv3/command/ep_command.go | 0.00% <0.00%> (ø) |
|
| etcdctl/ctlv3/command/make_mirror_command.go | 0.00% <0.00%> (ø) |
|
| etcdctl/ctlv3/command/global.go | 0.00% <0.00%> (ø) |
... and 22 files with indirect coverage changes
@@ Coverage Diff @@
## main #21010 +/- ##
==========================================
+ Coverage 69.21% 69.42% +0.21%
==========================================
Files 422 422
Lines 34841 34794 -47
==========================================
+ Hits 24114 24156 +42
+ Misses 9328 9245 -83
+ Partials 1399 1393 -6
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 7b1f0f2...c85f68d. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/retest
/hold