etcd icon indicating copy to clipboard operation
etcd copied to clipboard

Add server information to robustness response information

Open serathius opened this issue 2 months ago • 14 comments

What would you like to be added?

Add MemberId to from response header to the model.EtcdResponse. Ensure it's added to json response and visualized in the porcupine linearization.

Edit: Would be great to have this information showing in tooltip, for that we need https://github.com/anishathalye/porcupine/pull/39

/cc @sneaky-potato @henrybear327 @nwnt

Why is this needed?

Makes it easier to debug linearization failure

serathius avatar Nov 16 '25 17:11 serathius

/cc @joshjms

serathius avatar Nov 16 '25 17:11 serathius

I can have a look at it.

nwnt avatar Nov 16 '25 17:11 nwnt

/assign

nwnt avatar Nov 16 '25 17:11 nwnt

Hey, I see its still open, can i work on this?

slyt3 avatar Dec 05 '25 09:12 slyt3

I'd also be interested in working on this if possible!

jihogh avatar Dec 11 '25 07:12 jihogh

@nwnt are you still working on it?

serathius avatar Dec 11 '25 08:12 serathius

Once we figure out if nwnt is currently working on it do you mind if I take this one @slyt3 ? I’m new to etcd’s codebase and I’m not deeply familiar with gRPC or the client layer yet, but this issue seems like a great simple entry point to learn the request/response flow and the metadata propagation, if not I completely understand! Thank you so much!

jihogh avatar Dec 11 '25 08:12 jihogh

@jihogh Sure, go for it! 💪

slyt3 avatar Dec 11 '25 09:12 slyt3

Sounds great, I really appreciate it! Waiting on further guidance @serathius Thank you again!

jihogh avatar Dec 11 '25 09:12 jihogh

Yep, still working on this. had some progress but I was out of office for a while. will get something out by this week.

nwnt avatar Dec 11 '25 18:12 nwnt

@nwnt do you mind if I take a stab at this? Unless you already have significant work done and you wanna finish it! (is this poor form? I’m not 100% familiar with open source contributions, please let me know!) Just asking because it looks like a great first issue :)

jihogh avatar Dec 11 '25 19:12 jihogh

Sure, although I already some thing mid way, you can take a stab. I can help review once you have something ready too.

nwnt avatar Dec 11 '25 23:12 nwnt

Thank you so much! I really appreciate it!

jihogh avatar Dec 12 '25 10:12 jihogh

/assign

jihogh avatar Dec 12 '25 13:12 jihogh