etcd icon indicating copy to clipboard operation
etcd copied to clipboard

Refactor recording client management

Open nwnt opened this issue 7 months ago • 2 comments

Fix #19893

nwnt avatar Jun 15 '25 03:06 nwnt

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.20%. Comparing base (cc29bc0) to head (ae8a57f). Report is 32 commits behind head on main.

Additional details and impacted files

see 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20175      +/-   ##
==========================================
- Coverage   69.27%   69.20%   -0.08%     
==========================================
  Files         413      413              
  Lines       34364    34367       +3     
==========================================
- Hits        23805    23783      -22     
- Misses       9160     9180      +20     
- Partials     1399     1404       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d37ff81...ae8a57f. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 15 '25 03:06 codecov[bot]

@serathius sorry was away for a few days. How does the latest commit look?

nwnt avatar Jun 20 '25 03:06 nwnt

/retest

nwnt avatar Jun 22 '25 03:06 nwnt

This should fix all of them. Can I bother you to review again @serathius?

nwnt avatar Jun 22 '25 15:06 nwnt

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nwnt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 22 '25 17:06 k8s-ci-robot

/retest

serathius avatar Jun 22 '25 17:06 serathius