Refactor recording client management
Fix #19893
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.20%. Comparing base (
cc29bc0) to head (ae8a57f). Report is 32 commits behind head on main.
Additional details and impacted files
see 22 files with indirect coverage changes
@@ Coverage Diff @@
## main #20175 +/- ##
==========================================
- Coverage 69.27% 69.20% -0.08%
==========================================
Files 413 413
Lines 34364 34367 +3
==========================================
- Hits 23805 23783 -22
- Misses 9160 9180 +20
- Partials 1399 1404 +5
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d37ff81...ae8a57f. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@serathius sorry was away for a few days. How does the latest commit look?
/retest
This should fix all of them. Can I bother you to review again @serathius?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nwnt, serathius
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [serathius]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest