Add unit tests for etcdctl

[siyuanfoundation]

What would you like to be added?

Add unit tests for etcdctl. Tasks include:

• [ ] Add a fake client
• [ ] Add unit tests for most files in etcdctl/ctlv3/command

Why is this needed?

Right now all the changes to etcdctl can only manually tested, which is hard to verify for reviewers. To improve reliability, we need to have proper testing.

[siyuanfoundation]

/cc @ahrtr @serathius @fuweid @ivanvc @jmhbnz @hwdef

[hwdef]

I want to do this. Please assign it to me

[Elbehery]

/assign @hwdef

[Elbehery]

@siyuanfoundation Could this be split among many contributors ?

cc @ahrtr @ivanvc

[siyuanfoundation]

@siyuanfoundation Could this be split among many contributors ?

cc @ahrtr @ivanvc

Yes, I will break it into subtasks once the FakeClient fixture is added.

[Elbehery]

@siyuanfoundation Could this be split among many contributors ? cc @ahrtr @ivanvc

Yes, I will break it into subtasks once the FakeClient fixture is added.

thx for your response 👍🏽

Anyone is working on the FakeClient already ?

[hwdef]

@Elbehery If no one else does it, I'm willing to give it a try.

[Elbehery]

i assigned you last week already 🙂🙂

[hwdef]

Thanks! I'll submit PR in a few days.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

[hwdef]

still work in progress

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

[hwdef]

still work in progress