etcd icon indicating copy to clipboard operation
etcd copied to clipboard

chore: fix the output of `etcdctl watch -i`

Open JalinWang opened this issue 11 months ago • 11 comments

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow. image Although the interactive mode of etcdctl watch supports progress command now, the output is a little bit out-of-date :(

JalinWang avatar Feb 12 '25 07:02 JalinWang

Hi @JalinWang. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Feb 12 '25 07:02 k8s-ci-robot

Codecov Report

:x: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 70.29%. Comparing base (fefce54) to head (16b3c80). :warning: Report is 1441 commits behind head on main.

Files with missing lines Patch % Lines
etcdctl/ctlv3/command/watch_command.go 0.00% 4 Missing :warning:
Additional details and impacted files
Files with missing lines Coverage Δ
etcdctl/ctlv3/command/watch_command.go 44.08% <0.00%> (ø)

... and 66 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19397      +/-   ##
==========================================
+ Coverage   68.94%   70.29%   +1.34%     
==========================================
  Files         420      424       +4     
  Lines       35759    37961    +2202     
==========================================
+ Hits        24654    26684    +2030     
- Misses       9684     9845     +161     
- Partials     1421     1432      +11     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fefce54...16b3c80. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Feb 12 '25 08:02 codecov[bot]

/ok-to-test

ivanvc avatar Feb 14 '25 07:02 ivanvc

/ok-to-test

@JalinWang, can you squash your commits?

ivanvc avatar Mar 06 '25 14:03 ivanvc

done~

JalinWang avatar Mar 11 '25 06:03 JalinWang

/retest

ivanvc avatar Mar 12 '25 03:03 ivanvc

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 15 '25 00:05 github-actions[bot]

cc. @jmhbnz, @ahrtr, @serathius, @fuweid

ivanvc avatar May 22 '25 05:05 ivanvc

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, JalinWang, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 22 '25 06:05 k8s-ci-robot

Apart from https://github.com/etcd-io/etcd/pull/19397#discussion_r2102055501, other changes in this PR look good to me. thx

ahrtr avatar May 22 '25 09:05 ahrtr

@JalinWang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-e2e-amd64 16b3c80e22e77d504ddc67322daa9073298619a8 link true /test pull-etcd-e2e-amd64
ci-etcd-robustness-release36-amd64 16b3c80e22e77d504ddc67322daa9073298619a8 link true /test ci-etcd-robustness-release36-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar May 24 '25 18:05 k8s-ci-robot

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 29 '25 00:10 github-actions[bot]