etcd icon indicating copy to clipboard operation
etcd copied to clipboard

release: release (undraft) GitHub release from release script

Open ivanvc opened this issue 1 year ago • 10 comments

Release (updraft) GitHub release from the release script after creating it, avoiding the last manual step of this process. However, if the user answers no to the prompt, the script won't exit with a failure code, as it is still possible to manually release it.

I tested this in my fork, and it works as expected.

Part of #18604

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

ivanvc avatar Nov 12 '24 22:11 ivanvc

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.83%. Comparing base (ffb6ff9) to head (5279471). :warning: Report is 1235 commits behind head on main.

:warning: Current head 5279471 differs from pull request most recent head cc0e439

Please upload reports for the commit cc0e439 to get more accurate results.

Additional details and impacted files
Files with missing lines Coverage Δ
api/version/version.go 86.66% <ø> (ø)

... and 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18886      +/-   ##
==========================================
- Coverage   68.84%   68.83%   -0.01%     
==========================================
  Files         421      421              
  Lines       35900    35900              
==========================================
- Hits        24716    24713       -3     
+ Misses       9762     9757       -5     
- Partials     1422     1430       +8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffb6ff9...cc0e439. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Nov 12 '24 22:11 codecov-commenter

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 12 '25 22:03 k8s-ci-robot

/test pull-etcd-unit-test-386

ivanvc avatar Mar 20 '25 17:03 ivanvc

I'm parking this pull request again. I'm thinking that we can keep the draft release as we have now and release it using a GitHub action (after the released artifacts tests pass). Based on etcd-io/auger I know that we have the permissions to publish the release from an action.

ivanvc avatar Mar 20 '25 21:03 ivanvc

Note: I'll need to automate checking if it's a pre-release or if we should mark it as a release. I think it is doable with the following logic:

Pre-release

If there's a pre-release identifier (i.e., -alpha.0 from v3.6.0-alpha.0), mark it as a pre-release.

Latest version

  1. If the patch ends with 0 (i.e., 3.6.0), mark it as the latest release.
  2. If not,
    1. Get the latest release gh release list --json isLatest,tagName --jq '.[] | select(.isLatest) | .tagName'
    2. If the combination of the major and minor is the same as the release in question (i.e., v3.6), mark it as the latest release.

ivanvc avatar Mar 20 '25 21:03 ivanvc

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 20 '25 00:05 github-actions[bot]

@ivanvc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci-etcd-robustness-release36-amd64 cc0e4394220772e29523efb9ea0139ac83b817de link true /test ci-etcd-robustness-release36-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar May 24 '25 18:05 k8s-ci-robot

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 18 '25 00:08 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 20 '25 00:10 github-actions[bot]