etcd Add revision to reads in TXN to robustness test and add regression test

What would you like to be added?

Issue https://github.com/etcd-io/etcd/issues/18667 was not detected by robustness test because TXN we generate don't set revision in range. We should fix this gap.

TODO:

Add randomly adding revision to generating multiTXNOps https://github.com/etcd-io/etcd/blob/448fb7e36c11971d610bef241f2ffb7ddf39788d/tests/robustness/traffic/etcd.go#L301-L332
Add regression test make test-robustness-issue18667 like in https://github.com/etcd-io/etcd/pull/17680/files

Note, until fix for https://github.com/etcd-io/etcd/issues/18667 is merged, we cannot enable running this test by default. Might need to make setting revision optional and only run it as regression test, only later enabling it by default.

As discussed on Slack @henrybear327 volunteered to work on it.

Why is this needed?

Cover detect and prevent https://github.com/etcd-io/etcd/issues/18667

Oct 05 '24 09:10 serathius

Any progress?

Oct 24 '24 09:10 serathius

ping @henrybear327

Oct 26 '24 09:10 serathius

@serathius isn't https://github.com/etcd-io/etcd/issues/19009 a duplicated issue of this one?

I am working on this issue this week.

Mar 20 '25 16:03 henrybear327

@ArkaSaha30 are you still working on https://github.com/etcd-io/etcd/issues/18667? Or should I take over the task there? :)

Apr 15 '25 13:04 henrybear327

That's a separate issue about implementing an e2e tests, while this one is about robustness test.

Apr 15 '25 15:04 serathius

@ArkaSaha30 are you still working on https://github.com/etcd-io/etcd/issues/18667? Or should I take over the task there? :)

Sorry for the delay, I'll be taking it up this week.

Apr 15 '25 16:04 ArkaSaha30

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

Jun 15 '25 00:06 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

Aug 23 '25 00:08 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

Oct 23 '25 00:10 github-actions[bot]

https://github.com/etcd-io/etcd/pull/20454

This PR should have resolved this issue.

Oct 30 '25 03:10 hwdef