etcdserver: a non-empty raft log snapshot should always be available

[clement2026]

This PR is related to https://github.com/etcd-io/etcd/issues/17098

Purpose

As mentioned in https://github.com/etcd-io/etcd/pull/18459#issuecomment-2306636486, the goal of this PR is to create a non-empty raft log snapshot if none exists.

Key Updates

• Alter shouldSnapshot function
• Added integration tests in tests/integration/raft_log_snapshot_test.go
• Fixed failing tests

[k8s-ci-robot]

Hi @clement2026. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov-commenter]

:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 22.50000% with 31 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (2c53be7) to head (8ab968e). Report is 14 commits behind head on main.

:exclamation: Current head 8ab968e differs from pull request most recent head ccbec07

Please upload reports for the commit ccbec07 to get more accurate results.

Files with missing lines	Patch %	Lines
client/v3/kubernetes/client.go	0.00%	27 Missing :warning:
server/etcdserver/server.go	69.23%	3 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Files with missing lines	Coverage Δ
server/etcdserver/server.go	81.13% <69.23%> (-0.14%)	:arrow_down:
client/v3/kubernetes/client.go	0.00% <0.00%> (ø)

... and 22 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #18494   +/-   ##
=======================================
  Coverage   68.79%   68.79%           
=======================================
  Files         420      420           
  Lines       35489    35471   -18     
=======================================
- Hits        24413    24404    -9     
+ Misses       9646     9633   -13     
- Partials     1430     1434    +4     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c53be7...ccbec07. Read the comment docs.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clement2026 Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@clement2026: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ivanvc]

/ok-to-test

[clement2026]

Hey @serathius, it would be great if you could check this out when you have a moment. Thanks!

[ahrtr]

#18459 requires that a non-empty raft log snapshot is always available.

Can you explain this? Why a non-empty snapshot is always required? We don't have such restriction before.

[clement2026]

Can you explain this? Why a non-empty snapshot is always required? We don't have such restriction before.

@ahrtr sure, check out this comment for more details https://github.com/etcd-io/etcd/pull/18459#issuecomment-2295388421

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[clement2026]

After chatting with serathius, I've realized this PR isn’t needed anymore. I'll keep working on https://github.com/etcd-io/etcd/issues/17098 in a new PR. Closing this.