etcd icon indicating copy to clipboard operation
etcd copied to clipboard

Plan to release etcd v3.5.16

Open ivanvc opened this issue 1 year ago • 18 comments

What would you like to be added?

The etcd patch release criteria has been met for our release-3.5 stable release branch so we should release v3.5.16.

The list of commits included since the previous release is: v3.5.15...release-3.5:

  • https://github.com/etcd-io/etcd/pull/18358
  • https://github.com/etcd-io/etcd/pull/18388
  • https://github.com/etcd-io/etcd/pull/18395
  • https://github.com/etcd-io/etcd/pull/18398
  • https://github.com/etcd-io/etcd/pull/18394
  • https://github.com/etcd-io/etcd/pull/18421
  • https://github.com/etcd-io/etcd/pull/18430
  • https://github.com/etcd-io/etcd/pull/18439
  • https://github.com/etcd-io/etcd/pull/18451
  • https://github.com/etcd-io/etcd/pull/18446
  • https://github.com/etcd-io/etcd/pull/18458
  • https://github.com/etcd-io/etcd/pull/18457
  • https://github.com/etcd-io/etcd/pull/18461
  • https://github.com/etcd-io/etcd/pull/18476
  • https://github.com/etcd-io/etcd/pull/18474
  • https://github.com/etcd-io/etcd/pull/18489
  • https://github.com/etcd-io/etcd/pull/18517
  • https://github.com/etcd-io/etcd/pull/18514

Work in progress CHANGELOG is: https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md#v3516-tbc

List of pull requests we still need to backport from main to release-3.5 before the patch release is issued:

  • #13018
  • #18548

Release team

GitHub handle Role
@ivanvc Release lead
@jmhbnz Release advisor
@ArkaSaha30 Release shadow
@vivekpatani Release shadow

Why is this needed?

Regular patch releases are vital to ensure our users have bug-free and secure software.

ivanvc avatar Aug 22 '24 22:08 ivanvc

how about including https://github.com/etcd-io/etcd/issues/18480 in it.

liangyuanpeng avatar Aug 23 '24 02:08 liangyuanpeng

Do you consider this PR merged in 2021? ref: Why is this needed

JalinWang avatar Aug 23 '24 02:08 JalinWang

how about including #18480 in it.

@liangyuanpeng, I think it would be reasonable to add the bbolt version bump. We have #18488 and #18489, which are very close to being merged.

Do you consider this PR merged in 2021? ref: Why is this needed

@JalinWang, being this technically an (experimental) feature, I would like to hear @ahrtr / @serathius thoughts on this.

ivanvc avatar Aug 25 '24 03:08 ivanvc

Do you consider this PR merged in 2021? ref: Why is this needed

I have no objection on this. Please also see https://github.com/etcd-io/etcd/pull/13018#discussion_r1730275709

ahrtr avatar Aug 25 '24 07:08 ahrtr

@JalinWang, do you want to help backporting #13018 to release-3.5 (after we merge #18495)?

ivanvc avatar Aug 26 '24 03:08 ivanvc

@JalinWang, do you want to help backporting #13018 to release-3.5 (after we merge #18495)?

Sure. I will create a backporting PR per https://github.com/etcd-io/etcd/blob/4d42c0f86ac2762253a804fc5d9e6a25b80ef21b/Documentation/contributor-guide/release.md#patch-version-release (, where says the backporting commits "should be restricted to bug fixes and security patches" ? )

Update: I found the discussion about backporting here. The criteria seems to be not that clear :(

JalinWang avatar Aug 26 '24 06:08 JalinWang

@JalinWang, with Benjamin's approval, feel free to do the cherry-pick :)

ivanvc avatar Aug 27 '24 20:08 ivanvc

Hello @ivanvc , I would want to shadow the release of v3.5.16

ArkaSaha30 avatar Sep 03 '24 06:09 ArkaSaha30

Hi team (@ahrtr, @jmhbnz, @serathius, @spzala, @wenjiaswe), similar comment to the one from #18486. Would you want to be part of the release team for 3.5.16? I'm happy to lead this one, too, if needed.

ivanvc avatar Sep 03 '24 19:09 ivanvc

Hi @ArkaSaha30, can you help to do a pass on pull requests and issues that need to be backported? I'm using the following search: https://github.com/etcd-io/etcd/issues?page=1&q=is%3Aissue+label%3Atype%2Fbug+created%3A%3E%3D2024-07-20, and https://github.com/etcd-io/etcd/issues?q=is%3Apullrequest+label%3Atype%2Fbug+created%3A%3E%3D2024-07-20.

Thanks!

ivanvc avatar Sep 04 '24 04:09 ivanvc

Thanks for volunteering to lead 3.5.16 and 3.4.34 @ivanvc!

I see @ahrtr has agreed to be release advisor for 3.4.34, I am happy to be release advisor for 3.5.16.

I'm just coming back after being sick so I'll do some scope/backport review soon. Keen to set a date for the release and book in the release call 👍🏻

jmhbnz avatar Sep 04 '24 10:09 jmhbnz

Go 1.22.7 will be released tomorrow(5 September 2024) with CVE fixes, do we need to bump go for v3.5.16 in that case? ref: https://groups.google.com/g/golang-announce/c/vM0L-2IDlOU/m/R-gi-VMOBQAJ?utm_medium=email&utm_source=footer

ArkaSaha30 avatar Sep 04 '24 17:09 ArkaSaha30

Go 1.22.7 will be released tomorrow(5 September 2024) with CVE fixes, do we need to bump go for v3.5.16 in that case? ref: https://groups.google.com/g/golang-announce/c/vM0L-2IDlOU/m/R-gi-VMOBQAJ?utm_medium=email&utm_source=footer

Thanks for the reminder. I think we should bump go1.22.7 for both 3.5.x and 3.4.x.

ahrtr avatar Sep 04 '24 18:09 ahrtr

@ivanvc @wenjiaswe I'd like to shadow pls, if possible. Thank you.

vivekpatani avatar Sep 05 '24 18:09 vivekpatani

Go 1.22.7 will be released tomorrow(5 September 2024) with CVE fixes, do we need to bump go for v3.5.16 in that case? ref: https://groups.google.com/g/golang-announce/c/vM0L-2IDlOU/m/R-gi-VMOBQAJ?utm_medium=email&utm_source=footer

Go 1.22.7 has been released a few hours ago: https://groups.google.com/g/golang-dev/c/S9POB9NCTdk/m/b5s3OiTsAQAJ?utm_medium=email&utm_source=footer

ArkaSaha30 avatar Sep 05 '24 18:09 ArkaSaha30

@ArkaSaha30, thanks for the heads-up. I opened #18548 to track the update.

ivanvc avatar Sep 05 '24 18:09 ivanvc

Hi @vivekpatani, I was going to send a Slack message regarding this, but I don't know your username. Could you reach out to me on Slack (ivanvc)? Thanks.

Team (@ArkaSaha30, @jmhbnz, @vivekpatani), I know our time zones are spread, so I will suggest when we use it for our community meetings. Are you available next Tuesday (10th) or Wednesday (11th) at 11 a.m. PT? (which would be 6 a.m. NZST and 11:30 p.m. IST)

ivanvc avatar Sep 07 '24 00:09 ivanvc

Team (@ArkaSaha30, @jmhbnz, @vivekpatani), I know our time zones are spread, so I will suggest when we use it for our community meetings. Are you available next Tuesday (10th) or Wednesday (11th) at 11 a.m. PT? (which would be 6 a.m. NZST and 11:30 p.m. IST)

Sounds great - I can do either of those options 🙂

jmhbnz avatar Sep 07 '24 04:09 jmhbnz

We just released v3.5.16. We found the following improvements to the documentation:

  1. Step 5 can be simplified to do a single-branch checkout
  2. Step 6 should clarify that the release directory is in /tmp/etcd-release-${VERSION}/etcd/release/
  3. Step 8 mention to add the "Release" label to the announcement message

ivanvc avatar Sep 10 '24 18:09 ivanvc

We just released v3.5.16. We found the following improvements to the documentation:

  1. Step 5 can be simplified to do a single-branch checkout
  2. Step 6 should clarify that the release directory is in /tmp/etcd-release-${VERSION}/etcd/release/
  3. Step 8 mention to add the "Release" label to the announcement message

I will take it up

ArkaSaha30 avatar Sep 10 '24 18:09 ArkaSaha30

Closing, as there are no more remaining tasks. The release is here: https://github.com/etcd-io/etcd/releases/tag/v3.5.16

ivanvc avatar Sep 11 '24 19:09 ivanvc