etcd icon indicating copy to clipboard operation
etcd copied to clipboard

Plan to release etcd v3.5.15

Open ivanvc opened this issue 1 year ago • 3 comments

What would you like to be added?

The etcd patch release criteria has been met for our release-3.5 stable release branch so we should release v3.5.15.

The list of commits included since the previous release is: v3.5.14...release-3.5:

  • #18104
  • https://github.com/etcd-io/etcd/pull/18105
  • https://github.com/etcd-io/etcd/pull/18129
  • https://github.com/etcd-io/etcd/pull/18138
  • https://github.com/etcd-io/etcd/pull/18170
  • https://github.com/etcd-io/etcd/pull/18174
  • https://github.com/etcd-io/etcd/pull/18207
  • https://github.com/etcd-io/etcd/pull/18160
  • https://github.com/etcd-io/etcd/pull/18229

Work in progress CHANGELOG is: https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md#v3515-tbd

List of pull requests we still need to backport from main to release-3.5 before the patch release is issued:

  • TBD

Why is this needed?

Regular patch releases are vital to ensure our users have bug-free and secure software.

ivanvc avatar Jun 28 '24 22:06 ivanvc

After a sweep of fixes merged in the main branch after 3.5.14, I found these two potential backports:

  • https://github.com/etcd-io/etcd/pull/18186
  • https://github.com/etcd-io/etcd/pull/18108

Do we want to backport any of these?

I would appreciate another pair of eyes to do another pass.

I also volunteer to be a shadow for this release :)

ivanvc avatar Jun 28 '24 23:06 ivanvc

@spzala or @wenjiaswe did either of you want to lead this release? If not I am happy to volunteer as release lead.

Do we want to backport any of these?

Will do some review soon, we also need to take a close look at recent bug reports and see if anything needs to be included: https://github.com/etcd-io/etcd/issues?q=is%3Aissue+label%3Atype%2Fbug+created%3A%3E%3D2024-04-30

jmhbnz avatar Jun 28 '24 23:06 jmhbnz

We may want to hold the release after 7/2, as according to SIG-release's email

There is a Go update being released on 07/02

I do see some outstanding changes in the Go Release Dashboard. But I don't know how to check when the version will be released, and I'm not sure if it will come with another vulnerability fix.

ivanvc avatar Jun 29 '24 22:06 ivanvc

@jmhbnz Yes, I am happy to do the release. It's a short week in US, maybe I can do it next week?

wenjiaswe avatar Jul 01 '24 18:07 wenjiaswe

@jmhbnz Yes, I am happy to do the release. It's a short week in US, maybe I can do it next week?

SGTM - So release team will be:

Github handle Role
@jmhbnz Release advisor
@wenjiaswe Release lead
@ivanvc Release shadow

/assign @wenjiaswe, @ivanvc, @jmhbnz

jmhbnz avatar Jul 01 '24 18:07 jmhbnz

Would you guys be available Monday, July 8th, at 11 a.m. PT? I'll be out next week starting Tuesday, so I won't be available if you want to schedule it for later that day, which is fine by me, we could see if someone else wants to shadow :)

ivanvc avatar Jul 03 '24 22:07 ivanvc

@ivanvc @jmhbnz I will discuss with you two on chat. If anyone else interested in shadowing, please ping me in slack: wenjiaswe

wenjiaswe avatar Jul 03 '24 23:07 wenjiaswe

@jmhbnz, after updating Go to address vulnerabilities (#18269), I think we now can release 3.4.34, right?

ivanvc avatar Jul 05 '24 04:07 ivanvc

@jmhbnz, after updating Go to address vulnerabilities (#18269), I think we now can release 3.4.34, right?

What is the CVE score? NIST don't list it yet https://nvd.nist.gov/vuln/detail/CVE-2024-24791. Our patch release criteria is 7.5 https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/release.md#patch-release-criteria but I'm not opposed to start organising 3.4.34 anyway once this release is done.

jmhbnz avatar Jul 05 '24 04:07 jmhbnz

What is the CVE score? NIST don't list it yet https://nvd.nist.gov/vuln/detail/CVE-2024-24791. Our patch release criteria is 7.5

That's a good point. I think there's no rush, and ultimately, there are no other outstanding changes for 3.4 other than the Go update.

ivanvc avatar Jul 05 '24 04:07 ivanvc

Will do some review soon, we also need to take a close look at recent bug reports and see if anything needs to be included: https://github.com/etcd-io/etcd/issues?q=is%3Aissue+label%3Atype%2Fbug+created%3A%3E%3D2024-04-30

I reviewed these and couldn't find anything that caught my eye. Do we want to backport any of https://github.com/etcd-io/etcd/issues/18247#issuecomment-2197763466?

ivanvc avatar Jul 06 '24 04:07 ivanvc

I reviewed these and couldn't find anything that caught my eye. Do we want to backport any of #18247 (comment)?

Have raised backport proposals for both:

  • https://github.com/etcd-io/etcd/pull/18288
  • https://github.com/etcd-io/etcd/pull/18289

jmhbnz avatar Jul 06 '24 11:07 jmhbnz

Are we still expecting the 3.5.15 release this week? Thanks.

bearpaws avatar Jul 11 '24 20:07 bearpaws

We have scheduled this release for today, Friday, July 19th, at 1 pm PT.

ivanvc avatar Jul 19 '24 18:07 ivanvc

3.5.15 has been published: https://github.com/etcd-io/etcd/releases/tag/v3.5.15

wenjiaswe avatar Jul 19 '24 20:07 wenjiaswe

Improvement to do before 3.5.16:

  • Free space check: make sure you have at least 5GB
  • Add in the doc step 5: before publish, ensure the right tag is selected (@wenjiaswe to add to the doc)
  • when sending email to etcd-dev, make sure the pending email is approved by one of the approvers (maintainers)

wenjiaswe avatar Jul 19 '24 20:07 wenjiaswe

PLease also update the release date, thx

https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md#v3515-tbd

ahrtr avatar Jul 23 '24 07:07 ahrtr

Please also update the release date, thx

Done in #18355.

ivanvc avatar Jul 23 '24 18:07 ivanvc

All done.

ahrtr avatar Aug 01 '24 14:08 ahrtr

thx all.

ahrtr avatar Aug 01 '24 14:08 ahrtr