etcd-io
Support gRPC context propagation in grpcproxy
…e problem that watch exits when recvLoop exits but sendLoop still running
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Trying to fix https://github.com/etcd-io/etcd/issues/18011.
Hi @ximenzaoshi. Thanks for your PR.
I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Hi, @ximenzaoshi, thanks for your PR. It seems like you didn't sign your commit. Could you please amend your commit and push it again? so the developer certificate of origin (DCO) check passes, i.e:
git commit --amend --signoff # Fix the signed off trailer
git push --force
Hi @ximenzaoshi, it would be nice if the PR title could be updated! :)
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ximenzaoshi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci-etcd-robustness-release36-amd64 | 1282b0421923bbdcc6f11153d1336ff7bc392dfd | link | true | /test ci-etcd-robustness-release36-amd64 |
| ci-etcd-robustness-release34-amd64 | 1282b0421923bbdcc6f11153d1336ff7bc392dfd | link | true | /test ci-etcd-robustness-release34-amd64 |
| ci-etcd-robustness-release35-amd64 | 1282b0421923bbdcc6f11153d1336ff7bc392dfd | link | true | /test ci-etcd-robustness-release35-amd64 |
| pull-etcd-govulncheck-main | 1282b0421923bbdcc6f11153d1336ff7bc392dfd | link | true | /test pull-etcd-govulncheck-main |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@ximenzaoshi can you revisit this PR to try to get it merged? Thanks!
@ivanvc: Closed this PR.
In response to this:
Superseded by https://github.com/etcd-io/etcd/pull/20490.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.