etcd-io
feat: add etcd_debugging_lease_total gauge metric
Hi @jimmy-bro. Thanks for your PR.
I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Should I write unit tests? I'm willing to write unit tests for all the metrics in https://github.com/etcd-io/etcd/blob/main/server/lease/metrics.go
Should I write unit tests? I'm willing to write unit tests for all the metrics in https://github.com/etcd-io/etcd/blob/main/server/lease/metrics.go
Yes please include tests, refer to https://github.com/etcd-io/etcd/pull/17983 for examples of unit and integration metrics tests.